Repository navigation
feat(CD): add support for === and !== - #1983
Merged
Merged
Conversation
Contributor
Author
|
Travis failure is not related to the change (#1982) edit: rebased on top of the PR |
vicb
force-pushed
the
0519-cdIdentical
branch
3 times, most recently
from
May 19, 2015 11:58
8e78d58 to
1f2986a
Compare
Member
|
@vicb this LGTM based of my (very) limited knowledge of this code part. Thnx for taking care of this, I wasn't aware that we need to change those parts here as well. 馃憤 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to #1500
@pkozlowski-opensource you PR add support in the parser but not in the CD (which I think was the root cause of issue #1496).
Could you please review the PR ?