feat(lang): support const expressions in TS/JS and Dart#1796
Closed
pkozlowski-opensource wants to merge 2 commits into
Closed
feat(lang): support const expressions in TS/JS and Dart#1796pkozlowski-opensource wants to merge 2 commits into
pkozlowski-opensource wants to merge 2 commits into
Conversation
9a94cd5 to
4928db8
Compare
4928db8 to
3a3c661
Compare
Member
Author
|
Putting in M8 as it blocks some issues / PRs in M8 |
Contributor
There was a problem hiding this comment.
Do we need this at all then? My intention at least was that CONST_EXPR never appears in Dart land.
3a3c661 to
24df78e
Compare
Member
Author
|
@mprobst updated based on your comments (thnx for the review!), could you please take another look? I would like to land this one ASAP as it is blocking 2 issues for M8 |
Contributor
|
LGTM. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tbosch @mprobst is this what you had in mind for
constsupport?