Skip to content

refactor(router): don't run the change detection every time an outlet is activated - #16883

Merged
jasonaden merged 2 commits into
angular:masterfrom
vicb:0518-router
May 19, 2017
Merged

jasonaden merged 2 commits into
angular:masterfrom
vicb:0518-router

Conversation

@vicb

@vicb vicb commented May 19, 2017

Copy link
Copy Markdown
Contributor

fixed #16510

@mary-poppins

Copy link
Copy Markdown

The angular.io preview for 122dbb4c1ce444f0a31051021fa31a3b750dc429 is available here.

@vicb
vicb requested review from jasonaden and tbosch May 19, 2017 02:09
@vicb vicb added area: router action: review The PR is still awaiting reviews from at least one requested reviewer labels May 19, 2017
@mary-poppins

Copy link
Copy Markdown

The angular.io preview for 0bcb59a2c9dce557b311faa27b843b2c315e2c35 is available here.

@mary-poppins

Copy link
Copy Markdown

The angular.io preview for 817da26 is available here.

@jasonaden jasonaden left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jasonaden
jasonaden merged commit 5d4f543 into angular:master May 19, 2017
@vicb
vicb deleted the 0518-router branch March 6, 2018 22:23
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer area: router cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants