Repository navigation
Conversation
Currently router performs change detection eagerly on component when the component is assigned to RouterOutlet. Another change detection is than performed globally. This double change detection presents a problem for animations.
mhevery
force-pushed
the
router_animation
branch
from
April 28, 2017 22:24
c1283fd to
7933b5a
Compare
vicb
reviewed
May 1, 2017
| detach(): ComponentRef<any>; | ||
| } | ||
|
|
||
| export class ProxyRouterOutlet implements IRouterOutlet { |
Contributor
There was a problem hiding this comment.
should be implemented by RouterOutlet
vicb
reviewed
May 1, 2017
| delayApplys: Array<(delegate: IRouterOutlet) => void> = []; | ||
|
|
||
| get isActivated(): boolean { | ||
| return this.delegate!.isActivated; |
Contributor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently router performs change detection eagerly on component when the component is assigned to RouterOutlet. Another change detection is than performed globally. This double change detection presents a problem for animations.