fix(router): do not finish bootstrap until all the routes are resolve…#15121
Merged
Merged
Conversation
d053ee8 to
0be2dcd
Compare
angular#14762) Cherry-pick of 5df998d onto 2.4.x branch. DEPRECATION: Use `RouterModule.forRoot(routes, {initialNavigation: 'enabled'})` instead of `RouterModule.forRoot(routes, {initialNavigtaion: true})`. Before doing this, move the initialization logic affecting the router from the bootstrapped component to the boostrapped module. Similarly, use `RouterModule.forRoot(routes, {initialNavigation: 'disabled'})` instead of `RouterModule.forRoot(routes, {initialNavigation: false})`. Deprecated options: 'legacy_enabled', `true` (same as 'legacy_enabled'), 'legacy_disabled', `false` (same as 'legacy_disabled'). The "Router Initial Navigation" design document covers this change. Read more here: https://docs.google.com/document/d/1Hlw1fPaVs-PCj5KPeJRKhrQGAvFOxdvTlwAcnZosu5A/edit?usp=sharing
0be2dcd to
d237d66
Compare
vicb
approved these changes
Mar 13, 2017
Contributor
|
@vicb wrong label |
Contributor
|
@DzmitryShylovich thanks ! |
The value of
I was hoping this change would cause the router URL to be updated before |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…d (#14762)
Cherry-pick of 5df998d onto 2.4.x branch.
DEPRECATION:
Use
RouterModule.forRoot(routes, {initialNavigation: 'enabled'})instead ofRouterModule.forRoot(routes, {initialNavigtaion: true}).Before doing this, move the initialization logic affecting the router
from the bootstrapped component to the boostrapped module.
Similarly, use
RouterModule.forRoot(routes, {initialNavigation: 'disabled'})instead of
RouterModule.forRoot(routes, {initialNavigation: false}).Deprecated options: 'legacy_enabled',
true(same as 'legacy_enabled'),'legacy_disabled',
false(same as 'legacy_disabled').The "Router Initial Navigation" design document covers this change.
Read more here:
https://docs.google.com/document/d/1Hlw1fPaVs-PCj5KPeJRKhrQGAvFOxdvTlwAcnZosu5A/edit?usp=sharing
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: