Repository navigation
refactor(core): use flags in Renderer2.setStye instead of booleans - #15045
Conversation
There was a problem hiding this comment.
is flags & RendererStyleFlags2.DashCase much faster than hasVendorPrefix || hasImportant?
There was a problem hiding this comment.
No. But it's simpler to just have one argument than 2, especially if they are booleans (the call site reads much nicer...). Also its simpler to add more of these flags, as we don't need to change Renderer classes that just delegate (e.g. the AnimationRenderer, ...)
There was a problem hiding this comment.
thank you for the clarification
250a930 to
5a0f55e
Compare
BREAKING CHANGE: (since v4 rc.1) - `Renderer2.setStyle` no longer takes booleans but rather a bit mask of flags.
5a0f55e to
fd026a5
Compare
…angular#15045) BREAKING CHANGE: (since v4 rc.1) - `Renderer2.setStyle` no longer takes booleans but rather a bit mask of flags.
…angular#15045) BREAKING CHANGE: (since v4 rc.1) - `Renderer2.setStyle` no longer takes booleans but rather a bit mask of flags.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
BREAKING CHANGE: (since v4 rc.1)
Renderer2.setStyleno longer takes booleans but rather abit mask of flags.