Repository navigation
fix(platform-browser): setAttribute should work with xmlns namespace - #14874
Merged
Merged
Conversation
vicb
reviewed
Mar 4, 2017
Contributor
There was a problem hiding this comment.
- what about adding the xmlns NS ? (This should be the list of all supported NS).
- missing tests
Contributor
Author
|
@vicb added uri for |
Contributor
Author
|
@IgorMinar can you take a look please? it's a regression from 2.x |
|
Can this be merged in before the next RC? It is preventing any migration to 4.0.0.RC for my projects. |
Contributor
|
Same here, have to downgrade back to |
tbosch
approved these changes
Mar 23, 2017
tbosch
left a comment
Contributor
There was a problem hiding this comment.
Thanks, this is a good change!
Contributor
|
Thanks @DzmitryShylovich for fixing it and thanks @IgorMinar and @vicb for following up! 🍻 |
sis0k0
added a commit
to NativeScript/nativescript-angular
that referenced
this pull request
Mar 24, 2017
Platform attributes (such as :ios and :android) are passed as namespaces to the renderer in Angular 4. Caused by: angular/angular#14874.
sis0k0
added a commit
to NativeScript/nativescript-angular
that referenced
this pull request
Mar 24, 2017
Platform attributes (such as :ios and :android) are passed as namespaces to the renderer in Angular 4. Caused by: angular/angular#14874.
sis0k0
added a commit
to NativeScript/nativescript-angular
that referenced
this pull request
Mar 24, 2017
Platform attributes (such as :ios and :android) are passed as namespaces to the renderer in Angular 4. Caused by: angular/angular#14874.
hdeshev
added a commit
to NativeScript/nativescript-angular
that referenced
this pull request
Mar 28, 2017
Platform attributes (such as :ios and :android) are passed as namespaces to the renderer in Angular 4. Caused by: angular/angular#14874.
hdeshev
added a commit
to NativeScript/nativescript-angular
that referenced
this pull request
Mar 28, 2017
Platform attributes (such as :ios and :android) are passed as namespaces to the renderer in Angular 4. Caused by: angular/angular#14874.
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14865