Skip to content

[2.x only] fix(router): do not finish bootstrap until all the routes are resolved#14327

Merged
mhevery merged 1 commit into
angular:2.4.xfrom
vsavkin:router_bootstrap_fix_2x
Feb 9, 2017
Merged

[2.x only] fix(router): do not finish bootstrap until all the routes are resolved#14327
mhevery merged 1 commit into
angular:2.4.xfrom
vsavkin:router_bootstrap_fix_2x

Conversation

@vsavkin
Copy link
Copy Markdown
Contributor

@vsavkin vsavkin commented Feb 6, 2017

Fixes #12162

This is fix for the 2.x version.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@vsavkin vsavkin force-pushed the router_bootstrap_fix_2x branch from 259d2f2 to 419fd64 Compare February 6, 2017 19:22
@vsavkin vsavkin mentioned this pull request Feb 6, 2017
Closed
@vicb vicb changed the title fix(router): do not finish bootstrap until all the routes are resolved [2.x only] fix(router): do not finish bootstrap until all the routes are resolved Feb 7, 2017
@vsavkin vsavkin force-pushed the router_bootstrap_fix_2x branch 2 times, most recently from e9b355a to 1d1f10f Compare February 7, 2017 19:23
@vsavkin vsavkin force-pushed the router_bootstrap_fix_2x branch from 1d1f10f to 41dd62c Compare February 7, 2017 21:37
@mhevery mhevery force-pushed the 2.4.x branch 2 times, most recently from baae06b to 059085b Compare February 9, 2017 04:23
@mhevery mhevery merged commit 541de26 into angular:2.4.x Feb 9, 2017
@DzmitryShylovich
Copy link
Copy Markdown
Contributor

DzmitryShylovich commented Feb 19, 2017 •
edited
Loading

@vsavkin looks like this pr introduced a bug with CanLoad gurad #14588 (comment)

@jdonnal-sp-embedded jdonnal-sp-embedded mentioned this pull request Feb 20, 2017
Closed
This was referenced Feb 22, 2017
Closed
Closed
vicb added a commit to vicb/angular that referenced this pull request Feb 23, 2017
@vicb
Revert "fix(router): do not finish bootstrap until all the routes are…
5b2cf39 
… resolved (angular#14327)"

This reverts commit 541de26.
@vicb vicb mentioned this pull request Feb 23, 2017
Merged
IgorMinar pushed a commit that referenced this pull request Feb 27, 2017
@vicb @IgorMinar
revert: fix(router): do not finish bootstrap until all the routes are…
de36f8a 
… resolved (#14327)

This reverts commit 541de26 because it introduced a regression.

Closes #14681, #14588
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot Bot commented Sep 10, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mhevery mhevery mhevery approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vsavkin @DzmitryShylovich @mhevery @googlebot