Skip to content

BUG FIX: without specification, certain versions of bower install ./app/... - #1409

Closed
hdngr wants to merge 1 commit into
angular:masterfrom
hdngr:fix-bower
Closed

BUG FIX: without specification, certain versions of bower install ./app/...#1409
hdngr wants to merge 1 commit into
angular:masterfrom
hdngr:fix-bower

Conversation

@hdngr

@hdngr hdngr commented Apr 16, 2015

Copy link
Copy Markdown

...bower_components...

fixes bower to install in ./bower_components so build does not fail on gulp build.js

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@hdngr

hdngr commented Apr 16, 2015

Copy link
Copy Markdown
Author

I signed it!

On Thursday, April 16, 2015 at 3:01 PM, googlebot wrote:

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).
Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.
If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data (https://cla.developers.google.com/clas) and verify that your email is set on your git commits (https://help.github.com/articles/setting-your-email-in-git/).
If you signed the CLA as a corporation, please let us know the company's name.


Reply to this email directly or view it on GitHub (#1409 (comment)).

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

@mhevery

mhevery commented Apr 17, 2015

Copy link
Copy Markdown
Contributor

@IgorMinar / @tbosch do we even use bower? Can you comment and approve?

@hdngr

hdngr commented Apr 17, 2015

Copy link
Copy Markdown
Author

like I mentioned, gulp build.js fails unless the proper bower packages are installed... e.g. polymer

@mhevery mhevery closed this in b1bc792 Apr 21, 2015
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants