Skip to content

chore(build): gulp test.unit.cjs broken the second run #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marclaval wants to merge 1 commit into from
Closed

chore(build): gulp test.unit.cjs broken the second run #1333

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -684,6 +684,7 @@ gulp.task('test.unit.cjs/ci', function () {
gulp.task('test.unit.cjs', ['build.js.cjs'], function () {
//Run tests once
runSequence('test.unit.cjs/ci', function() {});

//Watcher to transpile file changed
gulp.watch(CONFIG.transpile.src.js.concat(['modules/**/*.cjs']), function(event) {
var relPath = path.relative(__dirname, event.path).replace(/\\/g, "/");
Expand All @@ -701,6 +702,7 @@ gulp.task('test.unit.cjs', ['build.js.cjs'], function () {
delete require.cache[id];
}
}
global.assert = undefined;
Copy link
Copy Markdown
Contributor

@vicb vicb Apr 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC this is a temporarily fix. If this is the case you might want to add a TODO comment with a link to a follow up issue ?

Copy link
Copy Markdown
Contributor

@mhevery mhevery Apr 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have created the #1340 and updated the PR.

runSequence('test.unit.cjs/ci', function() {});
});

Expand Down