Skip to content

docs(readme): add installation of pub as a pre-requisite#113

Closed
hswolff wants to merge 1 commit into
angular:masterfrom
hswolff:update-readme
Closed

docs(readme): add installation of pub as a pre-requisite#113
hswolff wants to merge 1 commit into
angular:masterfrom
hswolff:update-readme

Conversation

@hswolff
Copy link
Copy Markdown
Contributor

@hswolff hswolff commented Oct 28, 2014

I've never used dart before and as such didn't have pub set-up on my machine. This caused the initial set-up to fail.

This adds one line instructing the user to install pub.

Comment thread README.md Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be Install the Dart SDK & https://www.dartlang.org/tools/sdk/

@hswolff hswolff force-pushed the update-readme branch 2 times, most recently from d2a3ad4 to 6af942a Compare October 28, 2014 13:20
@hswolff
Copy link
Copy Markdown
Contributor Author

hswolff commented Oct 28, 2014

Updated!

Would you be open to adding an additional line to make note that you need to add pub to your shell path? That's why I linked to https://www.dartlang.org/tools/pub/installing.html originally.

@vicb
Copy link
Copy Markdown
Contributor

vicb commented Oct 28, 2014

+1 to mention the update of PATH, for pub and dartanalyzer

@hswolff
Copy link
Copy Markdown
Contributor Author

hswolff commented Oct 28, 2014

Updated :)

@mhevery mhevery added @LGTM action: merge The PR is ready for merge by the caretaker labels Oct 29, 2014
@mhevery mhevery closed this in abb3ee4 Oct 29, 2014
@hswolff hswolff deleted the update-readme branch October 29, 2014 12:34
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants