feat(compiler): Add support for setting attributes to Component host ele...#1052
Closed
marclaval wants to merge 1 commit into
Closed
feat(compiler): Add support for setting attributes to Component host ele...#1052marclaval wants to merge 1 commit into
marclaval wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Any reason why this test doesn't have expect(setterFn).toBe(otherSetterFn);
Contributor
There was a problem hiding this comment.
Seems like a closure is re-created each time, should it return a lazy initialized var instead ?
Contributor
There was a problem hiding this comment.
Or
setterFn = (element, value) => DOM.setInnerHTML(element, value);
->
setterFn = DOM.setInnerHTML
…element Fixes angular#1008 Fixes angular#1009 Closes angular#1052
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...ment
It fixes #1008 and #1009 by extending
@PropertySetterto support the same cases as[]do, e.g.attr.role,class.fooorstyle.width.