Skip to content

docs(readme): add missing prerequsite [karma-cli]#102

Closed
blakelapierre wants to merge 2 commits into
angular:masterfrom
blakelapierre:readme_system_dependencies
Closed

docs(readme): add missing prerequsite [karma-cli]#102
blakelapierre wants to merge 2 commits into
angular:masterfrom
blakelapierre:readme_system_dependencies

Conversation

@blakelapierre
Copy link
Copy Markdown
Contributor

I needed to also install karma-cli globally for the Tests section of README.md to work.

@pkozlowski-opensource
Copy link
Copy Markdown
Member

Hmm, I think one needs to install globally karma-cli, karma itself should be installed locally with npm install (disclaimer: haven't tested).

@blakelapierre
Copy link
Copy Markdown
Contributor Author

This PR modifies instructions in the README.md to include installing karma-cli globally.

@pkozlowski-opensource
Copy link
Copy Markdown
Member

@blakelapierre yeh, but it still says to install both karma and karma-cli globally. What I'm saying is that (probably) it is not necessary to install karma globally.

@blakelapierre
Copy link
Copy Markdown
Contributor Author

Ah, got it 👍

@blakelapierre
Copy link
Copy Markdown
Contributor Author

Tried it out in a local docker container. Seems to work :)

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants