Skip to content

fix(animations): properly reference body node for SSR environments - #23300

Closed
matsko wants to merge 1 commit into
angular:masterfrom
matsko:body_node_animations
Closed

fix(animations): properly reference body node for SSR environments#23300
matsko wants to merge 1 commit into
angular:masterfrom
matsko:body_node_animations

Conversation

@matsko

@matsko matsko commented Apr 10, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@matsko
matsko force-pushed the body_node_animations branch from be115e0 to c71a0fe Compare April 10, 2018 22:22
@mary-poppins

mary-poppins commented Apr 10, 2018

Copy link
Copy Markdown

You can preview be115e0 at https://pr23300-be115e0.ngbuilds.io/.

@mary-poppins

mary-poppins commented Apr 10, 2018

Copy link
Copy Markdown

You can preview c71a0fe at https://pr23300-c71a0fe.ngbuilds.io/.

@jasonaden jasonaden added the area: animations legacy animations package only. Otherwise use area: core. label Apr 12, 2018
@ngbot

ngbot Bot commented Apr 16, 2018

Copy link
Copy Markdown

Hi @matsko! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@matsko matsko mentioned this pull request May 1, 2018
Closed
@matsko
matsko force-pushed the body_node_animations branch from c71a0fe to 81d5f7f Compare May 1, 2018 22:51
@mary-poppins

mary-poppins commented May 1, 2018

Copy link
Copy Markdown

You can preview 81d5f7f at https://pr23300-81d5f7f.ngbuilds.io/.

@matsko
matsko force-pushed the body_node_animations branch from 81d5f7f to 694502d Compare May 11, 2018 22:52
@mary-poppins

mary-poppins commented May 11, 2018

Copy link
Copy Markdown

You can preview 694502d at https://pr23300-694502d.ngbuilds.io/.

@sis0k0

sis0k0 commented Jun 1, 2018

Copy link
Copy Markdown
Contributor

Hey @matsko! This PR fixes an important issue in {N}-Angular. Does it need more work? Can we help with anything?

@matsko
matsko force-pushed the body_node_animations branch from 694502d to a60b841 Compare June 5, 2018 18:46
@mary-poppins

mary-poppins commented Jun 5, 2018

Copy link
Copy Markdown

You can preview a60b841 at https://pr23300-a60b841.ngbuilds.io/.

IgorMinar
IgorMinar reviewed Jun 5, 2018
View reviewed changes
Comment thread packages/animations/browser/BUILD.bazel Outdated

@IgorMinar IgorMinar Jun 5, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@IgorMinar IgorMinar changed the title test(animations): properly reference body node for SSR environments fix(animations): properly reference body node for SSR environments Jun 5, 2018
IgorMinar
IgorMinar approved these changes Jun 5, 2018
View reviewed changes

@IgorMinar IgorMinar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the commit message to "fix(animations): .."

@IgorMinar IgorMinar added target: patch This PR is targeted for the next patch release action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jun 5, 2018
@matsko
matsko force-pushed the body_node_animations branch from a60b841 to 1635ac1 Compare June 18, 2018 18:04
@mary-poppins

mary-poppins commented Jun 18, 2018

Copy link
Copy Markdown

You can preview 1635ac1 at https://pr23300-1635ac1.ngbuilds.io/.

@matsko
matsko force-pushed the body_node_animations branch from 1635ac1 to 97d7fde Compare June 18, 2018 22:12
@mary-poppins

mary-poppins commented Jun 18, 2018

Copy link
Copy Markdown

You can preview 97d7fde at https://pr23300-97d7fde.ngbuilds.io/.

@matsko
matsko force-pushed the body_node_animations branch from 97d7fde to 38064d6 Compare June 18, 2018 22:25
@angular angular deleted a comment from buildsize Bot Jun 18, 2018
@mary-poppins

mary-poppins commented Jun 18, 2018

Copy link
Copy Markdown

You can preview 38064d6 at https://pr23300-38064d6.ngbuilds.io/.

@matsko matsko added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jun 19, 2018
@mhevery mhevery closed this in e8354ed Jun 20, 2018
mhevery pushed a commit that referenced this pull request Jun 20, 2018
@matsko @mhevery
test(animations): properly reference body node for SSR environments (#…
776bc38 
…23300)

PR Close #23300
@sis0k0 sis0k0 mentioned this pull request Jun 21, 2018
Closed
sis0k0 added a commit to NativeScript/nativescript-angular that referenced this pull request Jun 21, 2018
@sis0k0
fix(animations): inject document object in the animation engine
7d1bc55 
Caused by API changes in angular/angular#23300.
fixes #1393
@sis0k0 sis0k0 mentioned this pull request Jun 21, 2018
Merged
sis0k0 added a commit to NativeScript/nativescript-angular that referenced this pull request Jun 21, 2018
@sis0k0
fix(animations): inject document object in the animation engine (#1395)
379e958 
Should be merged with `rebase and merge`.
Caused by API changes in angular/angular#23300.

BREAKING CHANGE

You have to update your @angular/* dependencies to 6.0.6 due to changes
in the @angular/animations API.

fixes #1393
@matsko
matsko deleted the body_node_animations branch January 17, 2019 19:44
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 14, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@vikerman vikerman vikerman approved these changes
@IgorMinar IgorMinar IgorMinar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: animations legacy animations package only. Otherwise use area: core. cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@matsko @mary-poppins @sis0k0 @vikerman @IgorMinar @jasonaden @googlebot