Repository navigation
Use an injected DOCUMENT instead of the global 'document' object #22093
Description
I'm submitting a...
[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ x ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
Current behavior
The following code in @angular/animations package is assuming that a global 'document' object exists:
angular/packages/animations/browser/src/render/shared.ts
Lines 195 to 200 in 3f5a3d6
Expected behavior
Using an injected DOCUMENT object instead.
What is the motivation / use case for changing the behavior?
There is no global 'document' object in NativeScript. Defining a polyfill causes troubles with other node packages that will try to use specific methods from it.
Environment
Angular version: 5.2.4
Related to NativeScript/nativescript-angular#1144
Activity
matsko commentedon May 1, 2018
This guy fixes it: #23300
sis0k0 commentedon Jul 2, 2018
Fixed with #23300 in
@angular/animationsv6.1.0-beta.3. 10x!angular-automatic-lock-bot commentedon Sep 13, 2019
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.