feat(benchpress): Add extension for ff metrics reporting - #1976

The failures are because it's creating dart files from these js files. I'm not sure why it's doing that.

Let's leave the xpi in the sources for now, so we can get this change in as soon as possible. We can change the build later on.

Oh, wait, just found jpm, a node.js based replacement for cfx. Could you use this instead of the bash script, and just create the extension on the fly on every testrun, so we don't need to build/store it at all?

@hankduan Could you rename your files into .es6? Then Dart won't pick them up. Also, please remove the util folder in between and put the files under src//firefox_extension and test//firefox_extension.

Otherwise LGTM.

Oh, and we probably should run this test on every build as well :-)
Add a line here that starts a new protractor instance with your configuration and your test.

I fixed all the mentioned issues, and renamed all the js files to es6.

Can you talk a little about (or point me to the code with) the mechanism that angular uses to transform es6 to js? i.e. does it transform all the es6 files, or certain es6 files?
Part of this will help me understand https://github.com/angular/angular/blob/master/scripts/ci/test_e2e_js.sh#L32. i.e. it is referring to protractor-js.conf.js, but what's actually creating those files as they're not in the repo.

Hank,
we are transpiling our sources into the dist folder, from where our protractor-js.conf picks it up (see https://github.com/angular/angular/blob/master/protractor-shared.js#L114).

Hank, I merged your PR as I want to typscript'ify benchpress tomorrow. Please integrate the e2e test in another PR. Btw, do we still need the .gitingore fire?

We can remove
addon-sdk*

but we would still need
*.xpi

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}