Skip to content

benchpress: integrate with desktop firefox #353

Closed

Description

@tbosch

Firefox webdriver needs to get:

  • performance log
  • command for forcing gc

Activity

  1. added this to the milestone on Jan 15, 2015
  2. tbosch commented on Jan 15, 2015

    @tbosch
    ContributorAuthor
  3. juliemr commented on Feb 4, 2015

    @juliemr
    Contributor

    @hankduan is taking a look at this.

  4. hankduan commented on Mar 31, 2015

    @hankduan
    Contributor
  5. tbosch commented on Apr 1, 2015

    @tbosch
    ContributorAuthor

    This sounds great!
    On Tue, Mar 31, 2015 at 12:25 PM Hank Duan notifications@github.com wrote:

    Findings so far captured here:
    https://docs.google.com/document/d/17f9q9yOM4Z705Gj2RsC2KNY2kQDtbIsxMydYpM1YEBU/edit?usp=sharing

    You can also see https://github.com/hankduan/firefoxExtension for some
    sample code.

    —
    Reply to this email directly or view it on GitHub
    #353 (comment).

  6. hankduan commented on Apr 16, 2015

    @hankduan
    Contributor

    As noted in the doc, running the tests via a webdriver server prevents access to chrome authority and the file sdk (used for file I/O). Future directions for investigations are:

  7. hankduan commented on May 11, 2015

    @hankduan
    Contributor

    See https://github.com/hankduan/firefoxExtension for an update.

    The extension exposes 3 functions: startProfiler, stopAndRecord, and forceGC, which can be called via protractor (see https://github.com/hankduan/firefoxExtension/blob/master/spec.js).

    The functions should achieve approximately what is desired. However, I don't know what is the expected format for the profile JSON. Here's an example (corresponding to the spec.js mentioned): https://gist.githubusercontent.com/hankduan/c8496aebf77a0de7fa90/raw/gistfile1.json

  8. tbosch commented on May 12, 2015

    @tbosch
    ContributorAuthor

    So you solved the problem that you can now access these functions also
    during webdriver tests?

    On Mon, May 11, 2015 at 3:34 PM Hank Duan notifications@github.com wrote:

    See https://github.com/hankduan/firefoxExtension for an update.

    The extension exposes 3 functions: startProfiler, stopAndRecord, and
    forceGC, which can be called via protractor (see
    https://github.com/hankduan/firefoxExtension/blob/master/spec.js).

    The functions should achieve approximately what is desired. However, I
    don't know what is the expected format for the profile JSON. Here's an
    example (corresponding to the spec.js mentioned):
    https://gist.githubusercontent.com/hankduan/c8496aebf77a0de7fa90/raw/gistfile1.json

    —
    Reply to this email directly or view it on GitHub
    #353 (comment).

  9. hankduan commented on May 12, 2015

    @hankduan
    Contributor

    Yes, although I'm not certain what I did to fix it. It might be a browser upgrade or a config change. You should be able to try it out by checking out the xpi in my github repo

  10. tbosch commented on May 12, 2015

    @tbosch
    ContributorAuthor

    So the plugin should just forward the original data from Firefox to keep it
    as simple as possible. We will then add a new WebDriverExtension class to
    benchpress that does the transformation outside of the plugin.

    What would you think how long it takes to move the plugin to the Angular2
    repo and add unit and integration tests to it?
    On Mon, May 11, 2015 at 6:06 PM Hank Duan notifications@github.com wrote:

    Yes, although I'm not certain what I did to fix it. It might be a browser
    upgrade or a config change.

    —
    Reply to this email directly or view it on GitHub
    #353 (comment).

  11. hankduan commented on May 12, 2015

    @hankduan
    Contributor

    How do you want the data forwarded? Right now it just saves the data to a specified file.
    In terms of tests, I can add an integration test fairly quickly. Unit tests don't make much sense since this is just a wrapper over core firefox

  12. hankduan commented on May 19, 2015

    @hankduan
    Contributor

    See #1976

  13. removed this from the milestone on May 29, 2015
  14. tbosch commented on Jun 25, 2015

    @tbosch
    ContributorAuthor

    Done via 0949a4b. Thanks @hankduan !!

  15. angular-automatic-lock-bot commented on Sep 6, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  16. locked and limited conversation to collaborators on Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions