Repository navigation
"Maximum call stack size exceeded" when compiling component with no View template or templateUrl #1326
Description
Given
@Component({
selector: 'app'
})
@View({
})
class AppComponent {}
bootstrap(AppComponent);Angular fails with
Uncaught TypeError: Cannot redefine property: onclick
Uncaught RangeError: Maximum call stack size exceeded
There's an existing throw intended to handle views without a template or templateUrl, but it never gets hit because the viewDefinition's absUrl property gets set in Compiler#_buildRenderTemplate regardless.
Activity
fix(compiler): only sets viewDefinition absUrl if the view has either…
matthewjh commentedon Apr 12, 2015
See PR, which I think provides a quick fix for this issue.
Personally, though, I think it's a bit odd that
absUrlhas two slightly different uses: to store the URL of the template if there is one, and to store the URL of the component otherwise for stylesheet loading. Why not have bothabsUrl(to use for loading resources e.g. stylesheets) andtemplateUrlon aViewDefinition? Seems clearer.tbosch commentedon Apr 13, 2015
Thanks for catching this! Your PR looks good.
On Sun, Apr 12, 2015 at 10:14 AM Matthew Hill notifications@github.com
wrote:
fix(compiler): only sets viewDefinition absUrl if the view has either…
angular-automatic-lock-bot commentedon Sep 6, 2019
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.