Allow threads.js to function even with webpack node externals - #224

@andywer this would handle the absolute path returned by rebaseScriptPath() that you mentioned right?
I am assuming the absolute path you are talking about is something like /Users/chingyawhao/Documents

Cool! Pushed a commit introducing some minor code improvements. Yes, that was the absolute path that I meant – only replaced the check with path.isAbsolute(), so we can be sure it works with Windows paths, too.

That's some great stuff right here 🙂

Thanks @andywer

I have no idea how to do testing for this scenario though, I tried adding webpack-node-externals to the existing node test before these changes but it did not fail

@chingyawhao Yeah, I was thinking the same. Unfortunately I don't really have time to look into this right now either…

We should probably just merge the fix. Do you need it urgently, btw?

I'm able to make the changes inside node_modules so its no rush