Skip to content

Add AV1 color space parsing in MP4 atom parser #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 9 commits into from
Nov 2, 2023
Merged

Add AV1 color space parsing in MP4 atom parser #692

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4ded7e5
Add AV1 color space parsing in MP4 atom parser
haixia-meta Sep 27, 2023
f455e84
Address review comments on Av1BitstreamParser
Oct 12, 2023
9180790
Format files and add release note
microkatz Oct 18, 2023
834664b
Add a unit test to Mp4ExtractorTest with a small av1 sample with colo…
Oct 24, 2023
5a70bbf
Format with google-java-format
microkatz Oct 25, 2023
258f45f
Fix unit test problems with sample_with_av1c.mp4
Oct 25, 2023
5bca9d8
Use a shorter test file
Oct 25, 2023
9d43cda
Add av1C to atom list comment in colr atom parse
microkatz Oct 25, 2023
dc53028
Changed av1c parser from a class to a method
microkatz Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix unit test problems with sample_with_av1c.mp4
  • Loading branch information
Haixia Shi @microkatz
Haixia Shi authored and microkatz committed Nov 2, 2023
commit 258f45f874bb6dc40a1e075b0702a69920f0b4a1
2 changes: 1 addition & 1 deletion libraries/extractor/src/main/java/androidx/media3/extractor/mp4/AtomParsers.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1240,7 +1240,7 @@ private static void parseVideoSampleEntry(
bitdepthChroma = bitdepthLuma;
// See av1C atom syntax:
// https://aomediacodec.github.io/av1-isobmff/#av1codecconfigurationbox-syntax
parent.skipBytes(4); // skip to configOBUs[]
parent.skipBytes(1); // skip to configOBUs[]
Av1BitstreamParser parser = new Av1BitstreamParser(parent);
if (parser.parseSequenceHeader() && parser.colorDescriptionPresentFlag == 1) {
colorSpace = ColorInfo.isoColorPrimariesToColorSpace(parser.colorPrimaries);
Expand Down
Loading