Update device parameters for DevicePreviews#1684
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request simplifies the @Preview device specifications by using the 'dp' suffix and removing redundant parameters like shape and unit. A review comment suggests lowering the DPI for the tablet preview from 480 to 240 to more accurately represent standard hardware density for a device of that size.
JetNews/app/src/main/java/com/example/jetnews/utils/MultipreviewAnnotations.kt
Show resolved
Hide resolved
c9488cc to
f4eeb70
Compare
AjeshRPai
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address b/500283228