[JetChat] Add glance widget for JetChat App #1424#1425
Merged
mlykotom merged 24 commits intoandroid:mainfrom Jan 10, 2025
Merged
[JetChat] Add glance widget for JetChat App #1424#1425mlykotom merged 24 commits intoandroid:mainfrom
mlykotom merged 24 commits intoandroid:mainfrom
Conversation
# Conflicts: # Jetchat/app/src/main/java/com/example/compose/jetchat/components/JetchatDrawer.kt
mlykotom
reviewed
Oct 21, 2024
Jetchat/app/src/main/java/com/example/compose/jetchat/components/JetchatDrawer.kt
Outdated
Show resolved
Hide resolved
Jetchat/app/src/main/java/com/example/compose/jetchat/components/JetchatDrawer.kt
Outdated
Show resolved
Hide resolved
Jetchat/app/src/main/java/com/example/compose/jetchat/data/FakeData.kt
Outdated
Show resolved
Hide resolved
Jetchat/app/src/main/java/com/example/compose/jetchat/widget/composables/MessagesWidget.kt
Show resolved
Hide resolved
secondsun
suggested changes
Oct 28, 2024
Jetchat/app/src/main/java/com/example/compose/jetchat/widget/composables/MessagesWidget.kt
Outdated
Show resolved
Hide resolved
Jetchat/app/src/main/java/com/example/compose/jetchat/widget/composables/MessagesWidget.kt
Outdated
Show resolved
Hide resolved
Jetchat/app/src/main/java/com/example/compose/jetchat/widget/composables/MessagesWidget.kt
Outdated
Show resolved
Hide resolved
Jetchat/app/src/main/java/com/example/compose/jetchat/widget/WidgetReceiver.kt
Show resolved
Hide resolved
Contributor
Author
|
Thanks for the review @secondsun and @mlykotom will work on these over the weekend and will re-request a review. |
…troduced themes and text styles for glance widget.
Contributor
Author
|
@secondsun @mlykotom Can you guys take a look at the PR now ? |
secondsun
suggested changes
Nov 12, 2024
Contributor
secondsun
left a comment
There was a problem hiding this comment.
Found one thing with linting. Line is too long.
Jetchat/app/src/main/java/com/example/compose/jetchat/components/JetchatDrawer.kt
Outdated
Show resolved
Hide resolved
Jetchat/app/src/main/java/com/example/compose/jetchat/components/JetchatDrawer.kt
Show resolved
Hide resolved
Jetchat/app/src/main/java/com/example/compose/jetchat/components/JetchatDrawer.kt
Outdated
Show resolved
Hide resolved
secondsun
approved these changes
Jan 6, 2025
mlykotom
requested changes
Jan 8, 2025
Contributor
mlykotom
left a comment
There was a problem hiding this comment.
Pls check some of the comments, after that it's lgtm :)
Thank you and sorry for the long turnaround!
Jetchat/app/src/main/java/com/example/compose/jetchat/components/JetchatDrawer.kt
Outdated
Show resolved
Hide resolved
Jetchat/app/src/main/java/com/example/compose/jetchat/components/JetchatDrawer.kt
Show resolved
Hide resolved
Jetchat/app/src/main/java/com/example/compose/jetchat/JetchatApplication.kt
Outdated
Show resolved
Hide resolved
…kt class as initially implemented. Also propagating the requiresApi check to WidgetDiscoverability composable.
Contributor
Author
mlykotom
reviewed
Jan 9, 2025
Jetchat/app/src/main/java/com/example/compose/jetchat/data/messages/MessagesRepository.kt
Outdated
Show resolved
Hide resolved
Contributor
|
There's one more thing -- the unused |
mlykotom
approved these changes
Jan 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an Unreads widget for the JetChat app using Glance. Also has a option to add widget to home screen on the app.
Glance.Widget.Recording.webm
Fixes #1424