fix(web-awesome): expand top-level steps by default; fix keyboard shortcuts styling#683
Open
todti wants to merge 10 commits into
Open
fix(web-awesome): expand top-level steps by default; fix keyboard shortcuts styling#683todti wants to merge 10 commits into
todti wants to merge 10 commits into
Conversation
Top-level steps (direct children of the Test Body / Setup / Teardown sections) are now always open by default, regardless of the configured stepTreeExpansion policy. Nested steps continue to follow the policy.
… policy unchanged)
…er bar - Fix tree-item-marked using invisible --color-bg-secondary (same as canvas bg); replace with --color-row-bg-selected - Fix broken CSS tokens --bg-control-flat-medium and --bg-support-aldebaran in tree-item-focused and tree-section-focused; replace with --color-control-bg and --color-intent-primary-bg - Add useLayoutEffect in TreeList that scrolls to the marked test result when navigating via prev/next arrows (focusedId is cleared in that path) - Restructure split-mode layout: SplitLayout.wrapper becomes the scroll container for the entire left pane so the report header/metadata/root tabs scroll away; search + chips + status filter row stay sticky at top via position:sticky on ReportBody header
baev
approved these changes
Jun 3, 2026
…multi-env tree
- 'p' (navigate to parent group): use scrollIntoView({ block: start })
so the group always pins to top even when already visible — the old
scrollFocusIntoView returned delta=0 whenever the element was inside
the viewport, so the group never pinned
- trId effect: use flatTree lookup + data-tree-node-id query instead of
getElementById; getElementById returned the first of N duplicate ids
that exist when the same test result appears in multiple env sections
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's fixed
Top-level steps always expanded in test result body
Steps directly inside the Test Body, Setup, and Teardown sections were collapsing according to the
stepTreeExpansionpolicy (e.g. withexpand_failed_onlyall passed top-level steps appeared closed). The expectation is that top-level steps are always open by default — the user opens a test result to read it, not to click to expand every step. Nested steps continue to follow the configured policy.Added an
isTopLevelprop toTrBodyItemsandTrStep. Whentrue,openedByDefaultis alwaystrueregardless of policy. The rootTrBodyItemscall inTrSteps,TrSetup, andTrTeardownpassesisTopLevel={true}.Broken CSS design tokens in keyboard shortcuts panel
The keyboard shortcuts modal and the empty split-layout pane were using four CSS custom properties that don't exist in the design system (
--bg-base-primary,--bg-base-secondary,--on-text-secondary,--on-border-muted), causing transparent backgrounds and invisible borders. Replaced with the correct tokens:--bg-base-primary→--color-bg-raised--bg-base-secondary→--color-bg-neutral--on-text-secondary→--color-text-secondary--on-border-muted→--color-border-default