Skip to content

Add french translation#1151

Merged
baev merged 6 commits into
allure-framework:masterfrom
ZDGN-for-Git:master
Nov 5, 2020
Merged

Add french translation#1151
baev merged 6 commits into
allure-framework:masterfrom
ZDGN-for-Git:master

Conversation

@ZDGN-for-Git
Copy link
Copy Markdown
Contributor

Context

Adding translation file for french language

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 3, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown

@nantes44-github nantes44-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ligne 52 : pourquoi le "C" en majuscule?
ligne 161 : un "e" en trop
ligne 175 : il y a une faute d'orthographe (il manque un S)

Comment thread allure-generator/src/main/javascript/translations/fr.json Outdated
Comment thread allure-generator/src/main/javascript/translations/fr.json Outdated
Comment thread allure-generator/src/main/javascript/translations/fr.json Outdated
@baev
Copy link
Copy Markdown
Member

baev commented Nov 5, 2020

you also need to include it to translations.js file, plus add translations for plugins. As an example, see 769283c

@baev
Copy link
Copy Markdown
Member

baev commented Nov 5, 2020

the demo report for this PR available at https://ci.qameta.io/job/allure2/job/PR-1151/Demo_20Report/index.html

@baev baev merged commit d830da2 into allure-framework:master Nov 5, 2020
@baev
Copy link
Copy Markdown
Member

baev commented Nov 5, 2020

@ZDGN-for-Git thanks! 👍

@eroshenkoam eroshenkoam added the type:new feature Change that add something new for end users label Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:new feature Change that add something new for end users

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants