screen-diff-plugin: support multiple screen diffs per test via custom attachment view#1145
Merged
Merged
Conversation
just-boris
commented
Oct 18, 2020
Contributor
Author
|
Jenkins does not seem to publish demo report in the build artifacts. Uploaded the demo here: https://epic-villani-f00688.netlify.app |
Member
|
LGTM |
Contributor
Author
|
Status update: got this working locally with allure-mocha. Some more changes are required. Will try to do them as soon as I can. |
… attachement view closes allure-framework#613
baev
approved these changes
Nov 27, 2020
Member
|
@just-boris 👏 👏 👏 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
closes #613
Allow multiple screenshot differences via attachments. It should have the following format
{ "expected": "data:image/png;base64,....", "actual": "data:image/png;base64,....", "diff": "data:image/png;base64,...." }To support this, I extended plugin API allowing to register custom attachment views per mime type
Checklist