Skip to content

remove aspect warnings #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eroshenkoam merged 4 commits into from
Jul 2, 2017
Merged

remove aspect warnings #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
df563fb
reset warnings
Jul 2, 2017
1f822d8
fix javado
Jul 2, 2017
06925b6
fix import
Jul 2, 2017
a926d05
remove unused import
Jul 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 2 additions & 27 deletions allure-java-migration/src/main/java/io/qameta/allure/aspects/Allure1TestCaseAspects.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import org.aspectj.lang.JoinPoint;
import org.aspectj.lang.annotation.Aspect;
import org.aspectj.lang.annotation.Before;
import org.aspectj.lang.annotation.Pointcut;
import org.aspectj.lang.reflect.MethodSignature;

import java.util.Objects;
Expand All @@ -18,36 +17,12 @@ public class Allure1TestCaseAspects {

private static AllureLifecycle lifecycle;

/**
* Pointcut for things annotated with {@link org.junit.Test}.
*/
@Pointcut("@annotation(org.junit.Test)")
public void withJunitAnnotation() {
//pointcut body, should be empty
}

/**
* Pointcut for things annotated with {@link org.testng.annotations.Test}.
*/
@Pointcut("@annotation(org.testng.annotations.Test)")
public void withTestNgAnnotation() {
//pointcut body, should be empty
}

/**
* Pointcut for any methods.
*/
@Pointcut("execution(* *(..))")
public void anyMethod() {
//pointcut body, should be empty
}

@Before("anyMethod() && withJunitAnnotation()")
@Before("execution(@org.junit.Test * *.*(..))")
public void junitTestStart(final JoinPoint joinPoint) {
updateTestCase(joinPoint);
}

@Before("anyMethod() && withTestNgAnnotation()")
@Before("execution(@org.testng.annotations.Test * *.*(..))")
public void testNgTestStart(final JoinPoint joinPoint) {
updateTestCase(joinPoint);
}
Expand Down
1 change: 1 addition & 0 deletions allure-java-migration/src/main/resources/META-INF/aop-ajc.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,5 @@
<aspect name="io.qameta.allure.aspects.Allure1StepsAspects"/>
<aspect name="io.qameta.allure.aspects.Allure1AttachAspects"/>
</aspects>
<weaver options="-warn:none -Xlint:ignore"/>
</aspectj>