Added Interceptor for unary & server streaming gRPC calls#655
Conversation
|
|
|
I really like the idea of server interceptor with pretty printing. Should we merge our pull requests into one (my own is for client #646 ) ?
|
| dependency("org.jboss.resteasy:resteasy-client:4.7.1.Final") | ||
| dependency("org.mock-server:mockserver-netty:5.11.2") | ||
| dependency("org.mockito:mockito-core:3.12.4") | ||
| dependency("javax.annotation:javax.annotation-api:1.3.1") |
There was a problem hiding this comment.
I have not found any usages for the annotations from this dependency. Is this dependency really needed?
There was a problem hiding this comment.
This is the standard workaround for JDK 9+ (grpc/grpc-java#3633)
unfortunately the protoc compiler still uses javax.annotation.Generated annotation, but since JDK9 the annotation has been moved to package javax.annotation.processing.Generated
| description = "Allure gRPC Integration" | ||
|
|
||
| val agent: Configuration by configurations.creating | ||
|
|
There was a problem hiding this comment.
Please configure attributes: canbeconsumed=false, canberesolved=true, +attributes (runtime elements)
There was a problem hiding this comment.
Maybe provide a separate pull request with that change? We have it configured in such way in every module
| tasks.test { | ||
| useJUnitPlatform() | ||
| doFirst { | ||
| jvmArgs("-javaagent:${agent.singleFile}") |
There was a problem hiding this comment.
This should be done via jvmargumentsproviders: https://github.com/allure-framework/allure-gradle/search?q=JavaAgentArgumentProvider&type=
|
@dtuchs code style fails the build |
suppress some PMD checks up GRPC & protobuf versions
Uh oh!
There was an error while loading. Please reload this page.