Skip to content

Add hamcrest integration#642

Merged
baev merged 3 commits into
allure-framework:masterfrom
a-simeshin:add-hamcrest
Sep 3, 2021
Merged

Add hamcrest integration#642
baev merged 3 commits into
allure-framework:masterfrom
a-simeshin:add-hamcrest

Conversation

@a-simeshin
Copy link
Copy Markdown
Contributor

@a-simeshin a-simeshin commented Aug 30, 2021

Context

Adds hamcrest library integration https://github.com/hamcrest/JavaHamcrest
Docs http://hamcrest.org/JavaHamcrest/tutorial

Checklist

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Aug 30, 2021

CLA assistant check
All committers have signed the CLA.

@baev baev added the type:new feature Change that add something new for end users label Aug 30, 2021
@a-simeshin
Copy link
Copy Markdown
Contributor Author

@baev Hi there!
Would you be so nice to suggest a solution to this problem?

[Misc | NewlineAtEndOfFile] io.qameta.allure.hamcrest.(AllureHamcrestAssert.java:1)
  File does not end with a newline.
  http://checkstyle.sourceforge.io/config_misc.html#NewlineAtEndOfFile

Also could I fix this ⬇️ and this ⬆️ in the one commit?

[Imports | AvoidStarImport] io.qameta.allure.hamcrest.(AllureHamcrestAssert.java:4)
  Using the '.*' form of import should be avoided - org.aspectj.lang.annotation.*.
  http://checkstyle.sourceforge.io/config_imports.html#AvoidStarImport

@baev
Copy link
Copy Markdown
Member

baev commented Aug 31, 2021

And what is the problem, exactly?

To fix first problem you should add a new line at the end of AllureHamcrestAssert file, for second problem just expand wildcard import (all IDE's have a context action for that).

@a-simeshin
Copy link
Copy Markdown
Contributor Author

And what is the problem, exactly?

To fix first problem you should add a new line at the end of AllureHamcrestAssert file, for second problem just expand wildcard import (all IDE's have a context action for that).

Thanks for the explanation! Unfortunately, I am simply not familiar with the first problem. I`ll fix both problems soon

@a-simeshin
Copy link
Copy Markdown
Contributor Author

And what is the problem, exactly?

To fix first problem you should add a new line at the end of AllureHamcrestAssert file, for second problem just expand wildcard import (all IDE's have a context action for that).

The problem was the lack of .gitattributes that spotlessApply works with. Of course, plugin took the system eol = CRLF.
With * text eol = lf everything worked like a charm.

Done, ready for review.

@baev baev merged commit 2a00f36 into allure-framework:master Sep 3, 2021
@baev
Copy link
Copy Markdown
Member

baev commented Sep 3, 2021

good job 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme:build type:new feature Change that add something new for end users

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants