Skip to content

Disable test case creation for configuration failure results #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baev merged 1 commit into from
Nov 8, 2020
Merged

Disable test case creation for configuration failure results #489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions allure-testng/src/main/java/io/qameta/allure/testng/AllureTestNg.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@
import java.util.stream.Collectors;
import java.util.stream.Stream;

import static io.qameta.allure.util.ResultsUtils.ALLURE_ID_LABEL_NAME;
import static io.qameta.allure.util.ResultsUtils.bytesToHex;
import static io.qameta.allure.util.ResultsUtils.createFrameworkLabel;
import static io.qameta.allure.util.ResultsUtils.createHostLabel;
Expand Down Expand Up @@ -498,6 +499,15 @@ public void onConfigurationFailure(final ITestResult itr) {
final String parentUuid = UUID.randomUUID().toString();

startTestCase(itr, parentUuid, uuid);

// results created for configuration failure should not be considered as test cases.
getLifecycle().updateTestCase(
uuid,
tr -> tr.getLabels().add(
new Label().setName(ALLURE_ID_LABEL_NAME).setValue("-1")
)
);

stopTestCase(uuid, itr.getThrowable(), getStatus(itr.getThrowable()));
//do nothing
}
Expand Down
9 changes: 9 additions & 0 deletions allure-testng/src/test/java/io/qameta/allure/testng/AllureTestNgTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -974,6 +974,7 @@ public void shouldAddCorrectBeforeMethodFixturesInCaseOfParallelRun(
});
}

@SuppressWarnings("unchecked")
@AllureFeatures.Fixtures
@Issue("135")
@Test
Expand All @@ -992,6 +993,14 @@ public void shouldProcessConfigurationFailure() {
.extracting(TestResult::getStatusDetails)
.extracting(StatusDetails::getMessage)
.containsExactly("fail");

assertThat(results.getTestResults())
.filteredOn("name", "failed configuration")
.flatExtracting(TestResult::getLabels)
.extracting(Label::getName, Label::getValue)
.contains(
tuple("AS_ID", "-1")
);
}

@AllureFeatures.IgnoredTests
Expand Down