Skip to content

Task.add annotation label for link#354

Merged
baev merged 13 commits into
allure-framework:masterfrom
SergeyPirogov:task.add-annotation-label-for-link
May 20, 2019
Merged

Task.add annotation label for link#354
baev merged 13 commits into
allure-framework:masterfrom
SergeyPirogov:task.add-annotation-label-for-link

Conversation

@SergeyPirogov

@SergeyPirogov SergeyPirogov commented May 14, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Changes:
This PR corresponds to isssue #353 and add support for Link annotation labling.

Example:
I have test marked by Custom annotation Jira("Jira-456"), so I want to make Allure recognize it as Link and Story:

Before:

@Test
@Story("JIra-1")
@Link("Jira-1")
public void dummyTest(){}

After:

@LableAnnotation(name = "story")
@LableAnnotation(name = "link")
public @interface Jira {}

@Test
@Jira("JIra-1")
public void dummyTest(){}

Checklist

baev
baev requested changes May 14, 2019
View reviewed changes

@baev baev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request. I so happy that you like our new @LabelAnnotation feature. But could you please explain in more details what is the use-case of such behaviour for links? I'm ok with adding such functionality but I think we should design it more carefully at this point

Comment thread allure-attachments/build.gradle.kts Outdated
Comment thread allure-java-commons/src/main/java/io/qameta/allure/Link.java Outdated
Comment thread allure-java-commons/src/main/java/io/qameta/allure/util/AnnotationUtils.java Outdated
Comment thread allure-java-commons/src/main/java/io/qameta/allure/util/AnnotationUtils.java
Comment thread allure-java-commons/src/test/java/io/qameta/allure/util/AnnotationUtilsTest.java Outdated
Comment thread allure-java-commons/src/test/java/io/qameta/allure/util/AnnotationUtilsTest.java Outdated
@SergeyPirogov

SergeyPirogov commented May 16, 2019

Copy link
Copy Markdown
Contributor Author

@baev Please provide your feedback after comments fix

baev
baev requested changes May 16, 2019
View reviewed changes
Comment thread allure-java-commons/src/main/java/io/qameta/allure/util/ResultsUtils.java Outdated
Comment thread allure-java-commons/src/main/java/io/qameta/allure/LinkAnnotation.java Outdated
@baev baev merged commit c659614 into allure-framework:master May 20, 2019
@baev

baev commented May 20, 2019

Copy link
Copy Markdown
Member

@SergeyPirogov thanks!

@baev baev mentioned this pull request May 20, 2019
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baev baev baev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SergeyPirogov @baev