Allure cucumber jvm#35
Merged
Merged
Conversation
when feature tags are downstreamed for scenario outlines only
TODO: Pass Bebores and Afters
TODO: Fix skipped bug
baev
requested changes
Mar 20, 2017
| import gherkin.I18n; | ||
| import gherkin.formatter.Formatter; | ||
| import gherkin.formatter.Reporter; | ||
| import gherkin.formatter.model.*; |
| //include 'allure-junit5' | ||
| include 'allure-testng' | ||
|
|
||
| include 'allure-cucumber-jvm' No newline at end of file |
Member
|
you also need to fix all the pmd/checkstyle/findbugs issues |
Contributor
Author
Is these check done automatically? I can fix it in right way only if it will be hardly declared rules or automatically checked by right configured sonar of smth. similar. |
Member
|
simply run |
baev
requested changes
Mar 21, 2017
| import io.qameta.allure.model.StepResult; | ||
| import io.qameta.allure.model.TestResult; | ||
|
|
||
| import java.util.*; |
|
|
||
| import cucumber.runtime.CucumberException; | ||
| import cucumber.runtime.StepDefinitionMatch; | ||
| import gherkin.formatter.model.*; |
| } | ||
| } | ||
|
|
||
| public static String getStackTraceAsString(final Throwable throwable) { |
Member
There was a problem hiding this comment.
you can use ResultsUtils.getStatusDetails() instead
baev
approved these changes
Mar 21, 2017
Member
|
@clicman thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add allure-cucumber-jvm adaptor