Repository navigation
Fix allure-httpclient request without body - #313
Merged
Merged
Conversation
|
|
baev
requested changes
Jan 25, 2019
| import io.qameta.allure.attachment.AttachmentRenderer; | ||
| import io.qameta.allure.attachment.DefaultAttachmentProcessor; | ||
| import io.qameta.allure.attachment.FreemarkerAttachmentRenderer; | ||
| import io.qameta.allure.attachment.*; |
Member
There was a problem hiding this comment.
revert this change (in our project we are not using wildcard imports)
baev
approved these changes
Jan 25, 2019
Member
|
@useriq also in order to have this merged you need to link your commits with your Github account (see the bottom part of CLAassistant message) |
Contributor
Author
test was added |
baev
approved these changes
Jan 28, 2019
Member
|
@useriq thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case of receiving apache http response without body, exception occurs: IllegalArgumentException("Body may not be null");
But for response with 304 (Not Modified) code response body must be empty according to RFC: https://restfulapi.net/http-status-codes/ ( This status code is similar to 204 (“No Content”) in that the response body must be empty.
Current PR contains fix of that issue. In case of body absence, "No body is present" will be logged in the allure report.