Repository navigation
Skip JUnit Platform reporting when allure-cucumber8-jvm is present - #1499
Open
MohabMohie wants to merge 1 commit into
Open
MohabMohie wants to merge 1 commit into
MohabMohie wants to merge 1 commit into
Conversation
AllureJunitPlatform already deferred to allure-cucumber7-jvm for the cucumber engine. Extend the same classpath exclusion to allure-cucumber8-jvm so Cucumber 8 scenarios are not double-reported, and mirror the check in the TestNG and JUnit 4 adapters. Fixes allure-framework#1497
Contributor
Author
|
This repository requires exactly one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Fixes #1497.
AllureJunitPlatform.shouldSkipReportingForalready skips thecucumberengine whenallure-cucumber7-jvmis on the classpath, so the dedicated Cucumber adapter owns those scenarios. Afterallure-cucumber8-jvmlanded, the same double-reporting gap appeared for Cucumber 8: JUnit Platform still wrote empty top-level scenarios beside the real Cucumber 8 results.Changes
io.qameta.allure.cucumber8jvm.AllureCucumber8Jvmthe same way as Cucumber 7 and skip thecucumberengine when either adapter is present.AllureTestNgandAllureJunit4so the exclusion stays consistent across adapters.Verification
./gradlew :allure-junit-platform:test./gradlew :allure-junit4:compileJava :allure-testng:compileJava