Combining Repeatable annotations on method and on class#121
Merged
Conversation
# Conflicts: # allure-junit4/src/main/java/io/qameta/allure/junit4/Tag.java # allure-junit4/src/test/java/io/qameta/allure/junit4/FeatureCombinationsTest.java
eroshenkoam
approved these changes
Aug 2, 2017
baev
approved these changes
Aug 7, 2017
Member
|
@jkttt thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[//]: # (
. Thank you so much for sending us a pull request!
.
. Make sure you have a clear name for your pull request.
. The name should start with a capital letter and no dot is required in the end of the sentence.
. To link the request with isses use the following notation: (fixes #123, fixes #321)
.
. An example of good pull request names:
. - Add Russian translation (fixes #123)
. - Add an ability to disable default plugins
. - Support emoji in test descriptions
)
Context
Repeatable annotations like Tag, Feature etc. on class have been overwritten by method annotations.
This have been creating different processing of JUni4 and JUnit5 test annotations. And makes neccessery duplicit annotations on JUnit4 test methods. Which could be replaced by single annotations on test class.
Checklist