Skip to content

Update cask syntax#370

Merged
JohanAR merged 1 commit into
alievk:masterfrom
oxnr:master
Mar 3, 2021
Merged

Update cask syntax#370
JohanAR merged 1 commit into
alievk:masterfrom
oxnr:master

Conversation

@oxnr
Copy link
Copy Markdown
Contributor

@oxnr oxnr commented Feb 18, 2021

As of 2021 the cask syntax has changed.

@JohanAR
Copy link
Copy Markdown
Collaborator

JohanAR commented Feb 19, 2021

I don't know Mac ecosystem, but are changes like this pushed to everybody (I mean similar to as if MS makes a change to Windows 10, then it's reasonable to assume that all Windows 10 users will get this update) or will there be some people who have brew with the new syntax, and some who have the old?

@oxnr
Copy link
Copy Markdown
Contributor Author

oxnr commented Feb 19, 2021

Its a global change that affects all brew 3.0 users 0. If you're using an old version of brew, than the old syntax will work.

@JohanAR
Copy link
Copy Markdown
Collaborator

JohanAR commented Feb 19, 2021

What I'm trying to ask is if we update the doc to the new syntax, will the instructions stop working for everybody who uses the older version? Or is your proposed change compatible with both new and old? If not, I think it might be better to have both commands and tell people to pick the one corresponding to their brew version

@NinoScript
Copy link
Copy Markdown

Hello, I was about to write this same change.
Please merge this PR!

As it is right now, it just doesn't work.
image

@NinoScript
Copy link
Copy Markdown

NinoScript commented Mar 2, 2021

What I'm trying to ask is if we update the doc to the new syntax, will the instructions stop working for everybody who uses the older version? Or is your proposed change compatible with both new and old? If not, I think it might be better to have both commands and tell people to pick the one corresponding to their brew version

Brew updates itself when you use it, so it's hard to have an old version.
In fact this particular breaking change was a bit controversial, because the syntax was deprecated and removed in just a couple of months, breaking many continuous integration setups.

are changes like this pushed to everybody (I mean similar to as if MS makes a change to Windows 10, then it's reasonable to assume that all Windows 10 users will get this update)

Yes, so I recommend just having the new syntax.

@JohanAR JohanAR merged commit 92d664b into alievk:master Mar 3, 2021
@JohanAR
Copy link
Copy Markdown
Collaborator

JohanAR commented Mar 3, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants