Skip to content

refactor: remove dependent of shell from designer#1328

Merged
liujuping merged 1 commit into
developfrom
refactor/fix-circular-dep
Dec 8, 2022
Merged

refactor: remove dependent of shell from designer#1328
liujuping merged 1 commit into
developfrom
refactor/fix-circular-dep

Conversation

@JackLian

@JackLian JackLian commented Dec 6, 2022

Copy link
Copy Markdown
Collaborator

解除designer对shell的依赖

@JackLian JackLian requested a review from liujuping as a code owner December 6, 2022 08:35
@JackLian JackLian marked this pull request as draft December 6, 2022 08:42
@github-actions

github-actions Bot commented Dec 6, 2022

Copy link
Copy Markdown

Coverage report for packages/designer

St.
Category Percentage Covered / Total
🟢 Statements
97.22% (-0.01% 🔻)
2938/3022
🟢 Branches
89.65% (+0.02% 🔼)
1689/1884
🟢 Functions
98.75% (-0% 🔻)
869/880
🟢 Lines
97.38% (-0.01% 🔻)
2859/2936
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / designer.ts
95.15% (-0.2% 🔻)
81.95% (-0.06% 🔻)
100%
95.02% (-0.19% 🔻)

Test suite run success

384 tests passing in 42 suites.

Report generated by 🧪jest coverage report action from b67105f

@github-actions

github-actions Bot commented Dec 6, 2022

Copy link
Copy Markdown

Coverage report for packages/renderer-core

St.
Category Percentage Covered / Total
🟡 Statements 72.51% 889/1226
🟡 Branches 61.86% 558/902
🟡 Functions 69.18% 193/279
🟡 Lines 72.53% 874/1205

Test suite run success

91 tests passing in 8 suites.

Report generated by 🧪jest coverage report action from b67105f

@github-actions

github-actions Bot commented Dec 6, 2022

Copy link
Copy Markdown

Coverage report for packages/react-simulator-renderer

St.
Category Percentage Covered / Total
🔴 Statements 33.33% 110/330
🔴 Branches 14.29% 23/161
🔴 Functions 26.19% 22/84
🔴 Lines 33.85% 110/325

Test suite run success

2 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from b67105f

@JackLian JackLian force-pushed the refactor/fix-circular-dep branch from c11983b to 82b3527 Compare December 6, 2022 10:05
@JackLian JackLian marked this pull request as ready for review December 6, 2022 10:05
@JackLian JackLian force-pushed the refactor/fix-circular-dep branch 3 times, most recently from 199dd71 to 6ba7cc0 Compare December 8, 2022 02:27
@JackLian JackLian force-pushed the refactor/fix-circular-dep branch from 4bad8b1 to b67105f Compare December 8, 2022 02:43
@liujuping liujuping merged commit 6ae7c1b into develop Dec 8, 2022
@liujuping liujuping deleted the refactor/fix-circular-dep branch December 8, 2022 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants