Convert Modeldata to Dict#12
Merged
Merged
Conversation
…making the modelData class be it's own dict
aslisabanci
approved these changes
Nov 17, 2021
Contributor
aslisabanci
left a comment
There was a problem hiding this comment.
i like this simplification :) nothing stood out for me, so 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
user_dataandsystem_dataobjects of ModelData, and instead converts the modelData object itself into a dictionary type! This dramatically simplifies interactions in load functions, and allows for easy use by algorithm developers to store data that can later be used at runtime, without having to create a separate object, or reference a special member or method.Now if you want to export everything what was recorded in userspace, you simply need to call the
.data()method, which returns a dict containing the key/value pairs stored.