[Snyk] Fix for 3 vulnerabilities#700
Conversation
…s.txt to reduce vulnerabilities The following vulnerabilities are fixed by pinning transitive dependencies: - https://snyk.io/vuln/SNYK-PYTHON-TORCH-10332644 - https://snyk.io/vuln/SNYK-PYTHON-TORCH-10332645 - https://snyk.io/vuln/SNYK-PYTHON-WHEEL-15053866
Summary of ChangesHello @alejandrosuarez, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to enhance the security posture of the project by resolving three identified vulnerabilities within its Python dependencies. It achieves this by automatically updating specific package versions in the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request, automatically generated by Snyk, addresses three security vulnerabilities by pinning torch and wheel to newer versions in requirements.txt. The changes are necessary and correctly target the identified vulnerabilities. However, the PR description from Snyk highlights a few other potential dependency issues that are not addressed by this change:
transformersrequiressafetensors, which is not installed.multiprocessrequiresdill>=0.3.7, but an older version is present.
While this PR is a good step, it would be beneficial to investigate and resolve these additional dependency warnings in a follow-up to ensure the project's dependencies are fully healthy and consistent. I've also added a minor suggestion to improve the clarity of a comment in the requirements.txt file.
| ftfy | ||
| tensorboard | ||
| modelcards | ||
| torch>=2.10.0 # not directly required, pinned by Snyk to avoid a vulnerability |
There was a problem hiding this comment.
The comment # not directly required is a bit misleading. torch is a required transitive dependency for both torchvision and accelerate, which are listed as direct dependencies in this file. Making it an explicit dependency is good practice for version pinning, but the comment could be more accurate to reflect that it is a functional requirement.
torch>=2.10.0 # Pinned by Snyk to fix a vulnerability; required by torchvision and accelerate
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Snyk has created this PR to fix 3 vulnerabilities in the pip dependencies of this project.
Snyk changed the following file(s):
examples/research_projects/onnxruntime/text_to_image/requirements.txtImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Buffer Overflow
🦉 Directory Traversal