fix(manifest-server): return 400 for disallowed custom code#1020
Draft
Ilja Herdt (Airbyte) (iherdt-airbyte) wants to merge 1 commit into
Draft
fix(manifest-server): return 400 for disallowed custom code#1020Ilja Herdt (Airbyte) (iherdt-airbyte) wants to merge 1 commit into
Ilja Herdt (Airbyte) (iherdt-airbyte) wants to merge 1 commit into
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksTesting This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1778536209-builder-custom-code-error#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1778536209-builder-custom-code-errorPR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates the manifest-server
test_readsource-build path to convertAirbyteCustomCodeNotPermittedErrorinto a client-facing 400 response instead of letting it escape as a generic 500. This should make Cloud Connector Builder show the custom-code permission issue instead of an unknown error.Review & Testing Checklist for Human
Notes
Local checks run:
poetry --directory /home/ubuntu/repos/airbyte-python-cdk run pytest /home/ubuntu/repos/airbyte-python-cdk/unit_tests/manifest_server/routers/test_manifest.py -qpoetry --directory /home/ubuntu/repos/airbyte-python-cdk run ruff check /home/ubuntu/repos/airbyte-python-cdk/airbyte_cdk/manifest_server/routers/manifest.py /home/ubuntu/repos/airbyte-python-cdk/unit_tests/manifest_server/routers/test_manifest.pypoetry --directory /home/ubuntu/repos/airbyte-python-cdk run ruff format --check /home/ubuntu/repos/airbyte-python-cdk/airbyte_cdk/manifest_server/routers/manifest.py /home/ubuntu/repos/airbyte-python-cdk/unit_tests/manifest_server/routers/test_manifest.pymypyon the changed router was attempted but blocked by missing third-party stubs for existing imports (jsonschema,airbyte_protocol_dataclasses.models) in this local environment.Link to Devin session: https://app.devin.ai/sessions/9a396e45928647fe9673dc21e7846c71
Requested by: Ilja Herdt (Airbyte) (@iherdt-airbyte)