Use require.resolve to allow nested extend#582
Merged
Conversation
Collaborator
|
This seems like something eslint should be handling - |
Contributor
Author
|
Reading the existing discussion doesn't make it sound like they want to address this anytime soon. But I understand why you'd be uncomfortable with this change. |
Collaborator
|
This seems legit to me -- do linting & tests still pass after this change? |
Contributor
Author
|
The tests of this repo itself pass (e.g. running |
|
Keen to get this in :) This issue is preventing our internal config from upgrading to latest config. |
justjake
added a commit
that referenced
this pull request
Dec 15, 2015
Use require.resolve to allow nested extend
jgkim
referenced
this pull request
in tipplrio/eslint-config-tipplr
Dec 21, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default eslint always resolves files in
extendsrelative to the top-level project. Usingrequire.resolveconverts the references to absolute paths. Example:By default eslint will look for
eslint-config-airbnb/basein the top-level node_modules directory instead of one level down. By usingrequire.resolvethe "normal" npm resolution rules apply.We use this approach in
eslint-config-groupon. This change would allow us to get rid of the uglier parts in that repo.