Skip to content

[strings] fix example#261

Closed
hshoff wants to merge 1 commit into
masterfrom
hshoff/fix-strings-example
Closed

[strings] fix example#261
hshoff wants to merge 1 commit into
masterfrom
hshoff/fix-strings-example

Conversation

@hshoff
Copy link
Copy Markdown
Member

@hshoff hshoff commented Mar 27, 2015

Fixes:

The "bad" and "good" examples on using arrays to build long strings are not equivalent. If the array is empty, the "bad" code will return <ul></ul> and the "good" code will return <ul><li></li></ul>

http://www.reddit.com/r/javascript/comments/30hyan/airbnb_javascript_style_guide_a_mostly_reasonable/cpsngtz

Thanks Reddit 🍻

@goatslacker

@goatslacker
Copy link
Copy Markdown
Collaborator

There's also this PR: #260

@hshoff
Copy link
Copy Markdown
Member Author

hshoff commented Mar 27, 2015

doh.

@hshoff hshoff closed this Mar 27, 2015
@hshoff hshoff deleted the hshoff/fix-strings-example branch March 27, 2015 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants