🧪 Drop setup-python cache from the test job#622
Merged
webknjaz merged 1 commit intoaio-libs:masterfrom Feb 15, 2025
Merged
Conversation
This was referenced Feb 13, 2025
311b184 to
0f2e1db
Compare
9bd8718 to
e4d2161
Compare
The upstream `actions/setup-python` has rudimentary support for cache management but it's rather limited. It also has bugs in caching [[1]]. Having own reusable cache computation bit gives us better level of control, letting us make cache depend on specific Python runtime features. [1]: actions/setup-python#1034
e4d2161 to
75865cf
Compare
This was referenced Feb 15, 2025
webknjaz
added a commit
to webknjaz/ansible--awx-plugins
that referenced
this pull request
Feb 26, 2025
This action generalizes a piece of code for ABI-sensitive cache management that we were copying around. It also handles corner cases better than `actions/setup-python`. Refs: * https://github.com/marketplace/actions/cache-python-deps * https://github.com/re-actors/cache-python-deps * aio-libs/frozenlist#622 * aio-libs/frozenlist#633 * actions/setup-python#1034 * cherrypy/cheroot#739
webknjaz
added a commit
to sphinx-contrib/sphinxcontrib-towncrier
that referenced
this pull request
Feb 27, 2025
This action generalizes a piece of code for ABI-sensitive cache management that we were copying around. It also handles corner cases better than `actions/setup-python`. Refs: * https://github.com/marketplace/actions/cache-python-deps * https://github.com/re-actors/cache-python-deps * aio-libs/frozenlist#622 * aio-libs/frozenlist#633 * actions/setup-python#1034 * cherrypy/cheroot#739
webknjaz
added a commit
to ansible/awx_plugins.interfaces
that referenced
this pull request
Mar 4, 2025
This action generalizes a piece of code for ABI-sensitive cache management that we were copying around. It also handles corner cases better than `actions/setup-python`. Refs: * https://github.com/marketplace/actions/cache-python-deps * https://github.com/re-actors/cache-python-deps * aio-libs/frozenlist#622 * aio-libs/frozenlist#633 * actions/setup-python#1034 * cherrypy/cheroot#739
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an experimental attempt to work around the bug in
actions/setup-python@v5[1].