Skip to content

Add Content-Disposition automatically #8335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dreamsorcerer merged 8 commits into from
Apr 15, 2024
Merged

Add Content-Disposition automatically #8335

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e515273
Add Content-Disposition automatically
Dreamsorcerer Apr 15, 2024
ee711bb
Update test_multipart.py
Dreamsorcerer Apr 15, 2024
55bfdda
Update multipart.py
Dreamsorcerer Apr 15, 2024
fdfc0b5
Update test_multipart.py
Dreamsorcerer Apr 15, 2024
db6541f
Create 8335.bugfix.rst
Dreamsorcerer Apr 15, 2024
56d45e9
Update aiohttp/multipart.py
Dreamsorcerer Apr 15, 2024
834bcda
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 15, 2024
306b461
Update test_multipart.py
Dreamsorcerer Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update test_multipart.py
  • Loading branch information
@Dreamsorcerer
Dreamsorcerer authored Apr 15, 2024
commit 306b461ec1a84315a8070c116f16a1476feeb106
13 changes: 9 additions & 4 deletions tests/test_multipart.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1167,17 +1167,22 @@ def test_append_multipart(self, writer: Any) -> None:

def test_set_content_disposition_after_append(self):
writer = aiohttp.MultipartWriter("form-data")
payload = writer.append("some-data")
payload.set_content_disposition("form-data", name="method")
assert 'name="method"' in payload.headers[CONTENT_DISPOSITION]
part = writer.append("some-data")
part.set_content_disposition("form-data", name="method")
assert 'name="method"' in part.headers[CONTENT_DISPOSITION]

def test_automatic_content_disposition(self):
writer = aiohttp.MultipartWriter("form-data")
writer.append_json(())
part = payload.StringPayload("foo")
part.set_content_disposition("form-data", name="second")
writer.append_payload(part)
writer.append("foo")

disps = tuple(p[0].headers[CONTENT_DISPOSITION] for p in writer._parts)
assert 'name="section-0"' in disps[0]
assert 'name="section-1"' in disps[1]
assert 'name="second"' in disps[1]
assert 'name="section-2"' in disps[2]

def test_with(self) -> None:
with aiohttp.MultipartWriter(boundary=":") as writer:
Expand Down