Skip to content

Fix #216: HttpMessage._add_default_headers does not overwrite existing headers#219

Merged
asvetlov merged 2 commits into
masterfrom
issue_216_dont_override_headers
Jan 2, 2015
Merged

Fix #216: HttpMessage._add_default_headers does not overwrite existing headers#219
asvetlov merged 2 commits into
masterfrom
issue_216_dont_override_headers

Conversation

@asvetlov
Copy link
Copy Markdown
Member

@asvetlov asvetlov commented Jan 2, 2015

I have had drop SERVER and DATE from hop-by-hop headers also.
According to http://www.w3.org/Protocols/rfc2616/rfc2616-sec13.html 13.5.1 End-to-end and Hop-by-hop Headers those headers are not in hop-by-hop list.

@fafhrd91
Copy link
Copy Markdown
Member

fafhrd91 commented Jan 2, 2015

+1 for useragent

i'm not sure about server and date, here is reason:

# Server and Date aren't technically hop-by-hop
# headers, but they are in the purview of the
# origin server which the WSGI spec says we should
# act like. So we drop them and add our own.

@fafhrd91
Copy link
Copy Markdown
Member

fafhrd91 commented Jan 2, 2015

+1 for server and date

@kxepal
Copy link
Copy Markdown
Member

kxepal commented Jan 2, 2015

+1

asvetlov added a commit that referenced this pull request Jan 2, 2015
@asvetlov
Merge pull request #219 from KeepSafe/issue_216_dont_override_headers
26f380b 
Fix #216: HttpMessage._add_default_headers does not overwrite existing headers
@asvetlov asvetlov merged commit 26f380b into master Jan 2, 2015
@asvetlov asvetlov deleted the issue_216_dont_override_headers branch January 2, 2015 09:00
@lock
Copy link
Copy Markdown

lock Bot commented Oct 30, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock Bot added the outdated label Oct 30, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Oct 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

outdated

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@asvetlov @fafhrd91 @kxepal