Added testcase for compare agents in agents.py#395
Closed
articuno12 wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Hello @articuno12. There are some merge conflicts now + some issues in your code. Do you have the time to fix them, or can I take care of them for you? The main issue with the PR is grammar/English. First of all, I think the first three comments are unnecessary. Then, you use "preformance" in variable names, while it actually is "performance". There are some other grammar/spelling errors, like "as compare to", which should be "as compared to". If you don't have the time to fix this, please let me know so that I can use your test. Thank you. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added testcase for compare_agents in agents.py . #393
The performance of ModelBasedVacuumAgent will be atleast as good as that of ReflexVacuumAgent since ModelBasedVacuumAgent can identify when it has reached the terminal state ( both locations being clean) and will perform NoOp leading to 0 performance change , whereas ReflexVacuumAgent cannot identify the terminal state and thus would keep moving , leading to worse performance as compared to ModelBasedVacuumAgent.