add chapter 18 and 19 for 4th edition#1076
Merged
Merged
Conversation
Contributor
bruceyoungsysu
commented
Jun 16, 2019
- added util functions
- added and modified chapter 18 functions following the book.
- added test file
antmarakis
reviewed
Jun 20, 2019
|
|
||
|
|
||
| def simple_rnn_learner(train_data, val_data, epochs=2): | ||
|
|
Collaborator
There was a problem hiding this comment.
It would be great if you could add some description of the function, detailing what it does (is it just a general network?), what is the format of the data, etc. Right now it's hard to discern what this is trying to accomplish.
Contributor
Author
There was a problem hiding this comment.
Thanks for the reminder! I will also check other functions for the necessary comments.
Contributor
|
@bruceyoungsysu : Hi Bruce. There is one failing continuous integration test below. Can you fix this before I approve your pull request. I've attached a screen shot of the error. |
Contributor
|
Merged into master. |
dj5x5
pushed a commit
to dj5x5/aima-python
that referenced
this pull request
Jul 17, 2025
* chapter 18 learning * add chapter 19 * move init dataset in NN learner * add adam optimizer, add nn learner * remove cpt 19 for debug * change while loop in games4e * add chapter 19 * add sgd and adam optimizer * add chpt19 deep nn * add rnn * add auto encoder * add comments, correct tests * add more comments, change algorithms according to orders of chapter sections * add keras and numpy to requirements * add tf as requirement * add gc in test agent * fix agent bugs for running test_agent and test_agent_4e together * fix build error * add chapter 21 and 22 * add chapter 12 and part of 13 * remove chapter 12 and 13, add test of rl * modify rnn test * fix build error * Update utils4e.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.