Skip to content

Fix niceNum implementation #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danmooney2 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix niceNum implementation #122

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ead22d9
Fix niceNum implementation
danmooney2 Oct 20, 2022
732d9b9
Return string
danmooney2 Oct 20, 2022
1e06d5d
Throw error when argument passed to niceNum filter is NaN
danmooney2 Apr 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix niceNum implementation 
- Previous state was not locale-dependent
  • Loading branch information
@danmooney2
danmooney2 committed Oct 20, 2022
commit ead22d9d19d242354ee91b017d68305d0176e807
21 changes: 3 additions & 18 deletions js/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,26 +572,11 @@ if (/MSIE [5-9]/.test(navigator.userAgent)) {

app.filter("niceNum", function () {
return function (num) {
var niceNum = "";
var step = 1;

while (num >= 1) {
rest = num % 1000;

//Put it in a nice string
if (num > 1000) {
if (rest < 10) {
rest = "00" + rest;
} else if (rest < 100) {
rest = "0" + rest;
}
}

niceNum = rest + "'" + niceNum;
num = Math.floor(num / 1000);
if (!num || isNaN(num)) {
return 0;
}

return niceNum === "" ? "0" : niceNum.substring(0, niceNum.length - 1);
return parseInt(num, 10).toLocaleString();
};
});

Expand Down