revert code changes from PR#9343#9447
Merged
Merged
Conversation
Member
|
FYI @timchinowsky |
tannewt
approved these changes
Jul 22, 2024
Member
tannewt
left a comment
There was a problem hiding this comment.
Thanks for the fix. We can include the newer changes with another fix in main for 9.2.
This was referenced Jul 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts
PWMOut.ccode changes from #9343 to restore screen backlight functionality on SAMD51 boartds.Tested on a PyPortal (SAMD51) and Hallowing M0 (SAMD21).
I could not do an automated revert because of further changes in later PR's having to do with the tests and/or documentation. So those commits remain.
Interestingly, #9443 did not affect Hallowing M0 (SAMD21).