fix off-by-one in RP2040 PWM frequency setting#9398
Merged
Conversation
Collaborator
|
I think this makes sense, but I want to make sure you get 100% duty cycle if the duty cycle is set to 65535. Could you test that if you have not already. See #4192, which fixed some other (?) PWM off-by-one issues. I want to make sure this isn't a regression from that fix. |
Author
|
Here's data showing correct behavior at the extremes:
While I was at it I fixed the rounding issue that I had earlier addressed for Before
After
|
dhalbert
approved these changes
Jul 3, 2024
Collaborator
dhalbert
left a comment
There was a problem hiding this comment.
Great, thank you for the testing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting of
TOPinpwmioon RP2040 is off by one. CurrentlyTOPis set tocommon_hal_mcu_processor_get_frequency() / frequencybut from datasheet p. 527 that is too big by one: "if TOP is programmed to 254, the counter will have a period of 255 cycles." Verified that with current code PWM period resulting from requested 2500000 Hz PWM frequency is too long at 408 ns. With these changes frequency is exactly 400 ns as requested.