Only start BLE for workflow when desired#9344
Conversation
The previous implementation would always start BLE and rely on advertising logic to make the workflow not available when on USB. This change removes the "always enable" call in favor of a default value that is on if 1) we determine we should be discoverable or 2) we're already bonded over BLE.
|
@bill88t This should improve the RAM impact of BLE workflow. It won't match 9.0.x though because of the BLE related code in IRAM. |
|
I have good news and bad news. Good news first, from a quick test, this seems to bring back the ram usage back to normal.
I entered an optimization frenzy and now I'm at a net-negative ram usage. Bad news, brings back #9291.. somewhat. It no longer produces a crash. |
dhalbert
left a comment
There was a problem hiding this comment.
This makes sense to me.
The previous implementation would always start BLE and rely on advertising logic to make the workflow not available when on USB.
This change removes the "always enable" call in favor of a default value that is on if 1) we determine we should be discoverable or 2) we're already bonded over BLE.